Skip to content

support generics in from row and to row conversions#37347

Open
tilgalas wants to merge 1 commit intoapache:masterfrom
tilgalas:from-row-to-row
Open

support generics in from row and to row conversions#37347
tilgalas wants to merge 1 commit intoapache:masterfrom
tilgalas:from-row-to-row

Conversation

@tilgalas
Copy link
Contributor

@tilgalas tilgalas commented Jan 19, 2026

This is a 5th PR in the series of PRs (based on the now closed #31648) whose ultimate goal is to add support for generic classes to schema providers.

This PR builds on top of the previous PRs by updating "FromRow" and "ToRow" functions so that they understand the generic type information and can correctly perform the necessary conversions. With this PR we should be achieving full support for generics in schema providers.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 19, 2026

Summary of Changes

Hello @tilgalas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly advances the Apache Beam schema system by implementing robust support for generic types in FromRow and ToRow conversions. This enhancement is vital for allowing schema providers to accurately infer and utilize generic type information when mapping Java objects to Beam Rows and vice-versa. The changes span core schema logic, ensuring that complex generic structures are correctly processed, and are backed by extensive new tests to confirm the functionality across various object types like AutoValue, JavaBeans, and POJOs.

Highlights

  • Generic Type Support: This pull request introduces comprehensive support for generic types within the Apache Beam schema system, specifically enhancing FromRow and ToRow conversion functions.
  • Schema Provider Integration: The changes are a crucial step in a series of pull requests aimed at enabling schema providers to work seamlessly with generic classes, improving type safety and flexibility.
  • Core Schema Component Updates: Key modifications were made to FieldValueTypeInformation, FromRowUsingCreator, GetterBasedSchemaProvider, Row, RowWithGetters, and AutoValueUtils to correctly handle generic type information during schema operations.
  • Extensive Testing: Numerous new test cases have been added for AutoValue, JavaBean, and POJO schemas to validate the correct handling of generic types, including nested generics, maps, lists, and arrays, ensuring robustness of the new functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@tilgalas
Copy link
Contributor Author

tilgalas commented Jan 19, 2026

Run Java PreCommit

@tilgalas
Copy link
Contributor Author

tilgalas commented Jan 19, 2026

Run Java_IOs_Direct PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98
Copy link
Contributor

ahmedabu98 commented Jan 22, 2026

assign to next reviewer

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@kennknowles kennknowles self-requested a review January 23, 2026 15:46
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Reminder, please take a look at this pr: @chamikaramj

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@kennknowles
Copy link
Member

kennknowles commented Feb 17, 2026

Sorry for the slowness on review - it is a large change so it takes a lot to page in.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Reminder, please take a look at this pr: @ahmedabu98 @kennknowles

@tilgalas
Copy link
Contributor Author

tilgalas commented Feb 26, 2026

Sorry for the slowness on review - it is a large change so it takes a lot to page in.

No worries, I appreciate the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennknowles kennknowles Awaiting requested review from kennknowles

Assignees

No one assigned

Labels

aws extensions io java Next Action: Reviewers reassigned-reviewers slow-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tilgalas @ahmedabu98 @kennknowles